pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054 )
Change subject: enb: add abstract method stop() ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054/3/src/osmo_gsm_tester/obj/enb.py File src/osmo_gsm_tester/obj/enb.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054/3/src/osmo_gsm_tester/obj/enb.py@331 PS3, Line 331: raise log.Error('stop() not implemented!') This should stay as "pass", since it's abstract and code in it is never going to be executed, because python will fail when allocating the child class or this parent class. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181 Gerrit-Change-Number: 22054 Gerrit-PatchSet: 3 Gerrit-Owner: srs_andre <an...@softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sat, 09 Jan 2021 15:38:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
