dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 )
Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers ...................................................................... Patch Set 13: (2 comments) > Patch Set 12: Code-Review-1 > > my last comments were not still addressed. Looks like I overlooked these. https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c@29 PS10, Line 29: #include <osmocom/gsm/cbsp.h> > why do you include cbsp here? The deocde_cell_id_u func is declared in > osmocom/gsm/gsm0808_utils. […] Done https://gerrit.osmocom.org/c/libosmocore/+/21862/10/src/gb/gprs_bssgp_rim.c@55 PS10, Line 55: rc = gsm0808_decode_cell_id_u((union gsm0808_cell_id_u*)&cont->reprt_cell, > You cannot do this cast, the gprs_ra_id struct you are using is not > compatible and not part of cell_ […] I am using struct osmo_cell_global_id_ps for cont->reprt_cell and this is part of union gsm0808_cell_id_u. I was using gprs_ra_id before, but I migrated to osmo_cell_global_id_ps, so it should be correct, or not? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jan 2021 20:16:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
