lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22318 )
Change subject: gprs_ns2: correct handle BLOCK message on initator ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/22318/1/src/gb/gprs_ns2_vc_fsm.c File src/gb/gprs_ns2_vc_fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/22318/1/src/gb/gprs_ns2_vc_fsm.c@350 PS1, Line 350: osmo_timer_del(&fi->timer); > why is this timer deleting? it we are blocked I'd expect this to be a NOP, > and simply send an ACK. the timer doesn't need to be started. I've removed it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie7b34b3ef04aa28304143191222324e1a3786cb2 Gerrit-Change-Number: 22318 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 19 Jan 2021 19:22:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
