keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/22311 )

Change subject: Add vty command to show summary of all or filtered subscribers
......................................................................


Patch Set 7:

> Patch Set 7:
>
> > Patch Set 7:
> >
> > What about scheduling a timer for a few ms later after printing every X 
> > records, then exiting?
>
> This sounds like over-complication for no benefit to me. Even if you schedule 
> the guard timer, it would never expire until you finish everything in the 
> current select() loop iteration.

Thanks, yes. I tried to figure out if it could be done,  It looks like a lot 
for not much.
Really not sure how to deal with this. I'm also not sure how the C 
implementation of sqlite3 works and what the implications doing SELECT * from 
..... on a table with several hundred thousand records is.

Should be sql also include LIMIT and OFFSET or is it just the blocking vty 
printing to be concerned about?


--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/22311
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I7f0573381a6d0d13841ac6d42d50f0e8389decf4
Gerrit-Change-Number: 22311
Gerrit-PatchSet: 7
Gerrit-Owner: keith <ke...@rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-CC: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jan 2021 19:53:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to