dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )
Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si ...................................................................... Patch Set 3: (4 comments) > Patch Set 1: Code-Review-2 > > We cannot just bump the protocol version here, as we also need to test the > 'latest' osmo-pcu. See my comments to the related changes for osmo-pcu. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/Osmocom_Gb_Types.ttcn File library/Osmocom_Gb_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/Osmocom_Gb_Types.ttcn@2814 PS2, Line 2814: function tr_RAN_Information_Application_Container_NACC(template BssgpCellId cid := ?, template boolean psi_type := ?, > You probably want to push all these templates and functions as a separate > patch Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn@229 PS2, Line 229: variant (trx) "CROSSTAG(v09, version = 10; v10, version = 11)" > these lines changed here look wrong to me. I think I understand this now. This selects which specific type versions of trx and remote address we use. When version = 9, then pick trx type v09. In contrast to the comment above, the manual says that we can have N key = constant pairs and this means we can support N PCUIF versions, but all must be listed here. I have now added a version 11 that uses trx and remote_addr type v10. Also see jenkins.sh docker-playground/ttcn3-pcu-test, there we set mp_pcuif_version := 9 if we are on latest. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn@3659 PS2, Line 3659: f_init_raw(testcasename()); > you can pass info_ind as a second parameter here, no need to do the > BTS.send() below. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn@3717 PS2, Line 3717: f_sleep(0.2); /* i.e. give the IUT some time to process everything */ > which is exactly the problem you are having here? […] I copied this from other tests that use PCUIF, but it seems not to be necessary in my case because when I remove it the tests still work fine. PCU_Tests_NS seems to lack stuff I need, I will keep the testcases here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 27 Jan 2021 14:58:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
