pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )
Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si ...................................................................... Patch Set 3: > Patch Set 3: > > I still don't like this approach, sorry. And still don't understand why you > prefer it. Just imagine that we would need to send another type of System > Information, e.g. SI4. This would require you to bump the protocol version > again. If it's possible to avoid bumping the version, I would definitely > avoid doing it. You can easily support new and old versions (be backward compatible) if you add the fields at the end of the struct, I see no problem there. Older implementations won't see those fields and won't access them. The only benefit I see in adding a new message type to send SI information is that if they change more frequently, then we don't need to send the entire info_ind to the pcu and make it parse all of it again. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 27 Jan 2021 15:39:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
