dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )
Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si ...................................................................... Patch Set 4: (5 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn@229 PS2, Line 229: variant (trx) "CROSSTAG(v09, version = 10; v10, version = 11)" > Oh, I was looking at the patchset 2 all the time... Sorry. Yep, it's better > there. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn@919 PS2, Line 919: ? > '?' implies that the field is always present (not omit). This would break > PCUIFv10. Yes, I noticed that there is a problem while testing with V10 in docker. I have changed it to * in patchset 3 https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/3/library/PCUIF_Types.ttcn File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/3/library/PCUIF_Types.ttcn@347 PS3, Line 347: case else { len := 0; } > version 11 is missing here Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/3/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/3/pcu/PCU_Tests.ttcn@3603 PS3, Line 3603: var octetstring si1_expect := '198fb100000000000000000000000000007900002b'O; > fyi, I'm adding these as global "const si*_default" in some of my gerrit > patches for PCU_Tests (stil […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/3/pcu/PCU_Tests.ttcn@3785 PS3, Line 3785: > fix whitespace Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 28 Jan 2021 21:21:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
