fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )
Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/4/library/PCUIF_Types.ttcn File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/4/library/PCUIF_Types.ttcn@224 PS4, Line 224: OCT23 si1 optional, > This encoding is ambiguous. […] Or would you always send OCT23 as sequence of 0x00 even if siX_is_set == 0? If the whole set of fields is optional (what I guess is the case here), then you could just group it into an anonymous record and add 'optional' to it. So either all fields are present, or absent. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 28 Jan 2021 21:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
