fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/22385 )

Change subject: Introduce NACC support
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22385/11/src/nacc_fsm.c
File src/nacc_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22385/11/src/nacc_fsm.c@633
PS11, Line 633: connect to CTRL
> I Don't see a problem given that the log category is already NACC, but I can 
> change the message in a […]
Yes, please. It may still be not obvious where this 'NACC' subsystem is trying 
to connect, and a CTRL [server] can be everywhere (e.g. in osmo-bts).



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca
Gerrit-Change-Number: 22385
Gerrit-PatchSet: 12
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jan 2021 15:26:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to