laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22544 )
Change subject: gsm_7bit_encode_n(): fix integer overflow in gsm_septets2octets() ...................................................................... Patch Set 1: Code-Review-1 I don't think you can do that without breaking the ABI. So it's best to introduce a new function [name] for the changed function signature. Otherwise we risk breaking running old applications against new library. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib1aac538afeb0a5c76a1df472d555139a496e12e Gerrit-Change-Number: 22544 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 30 Jan 2021 14:17:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
