lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22553 )
Change subject: osmo-ns-dummy: Add simple NS traffic generator ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/22553/2/utils/osmo-ns-dummy-vty.c File utils/osmo-ns-dummy-vty.c: https://gerrit.osmocom.org/c/libosmocore/+/22553/2/utils/osmo-ns-dummy-vty.c@189 PS2, Line 189: if (ntg->running) { I would have used osmo_timer_pending() instead of running -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iad3b694c85962dbbc6b4a27a0ed5bc841add464f Gerrit-Change-Number: 22553 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Mon, 01 Feb 2021 00:29:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
