pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13338 )
Change subject: make use of OTC_GLOBAL when allocating library-internal contexts ...................................................................... Patch Set 23: Code-Review-1 (5 comments) https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/gsm/lapd_core.c File src/gsm/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/gsm/lapd_core.c@257 PS23, Line 257: __thread void *tall_lapd_ctx; I'd say adding __thread here is actually a different fix/commit. https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/gsm/lapdm.c File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/gsm/lapdm.c@129 PS23, Line 129: extern __thread void *tall_lapd_ctx; same (__thread) https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/logging.c File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/logging.c@1066 PS23, Line 1066: * \param[in] ctx should be NULL; only used for egacy API compatibility typo: legacy https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/signal.c File src/signal.c: https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/signal.c@42 PS23, Line 42: static void *tall_sigh_ctx2; why not reuse the tall_sigh_ctx and make it static once we get rid of its use in openbsc? https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/vty/telnet_interface.c@78 PS23, Line 78: * \param[in] tall_ctx should be NULL; nly for legacy API compatibility typo: only -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48f475efd3ee0d5120b8fc30861e852d1a6920b1 Gerrit-Change-Number: 13338 Gerrit-PatchSet: 23 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 03 Feb 2021 12:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
