pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037 )

Change subject: iperf3: return 0 if iperf results can't be read back
......................................................................


Patch Set 9:

I added +2 here, but thinking about it, does it really make sense to mask the 
exception by default and return 0? I'm not that sure.

Id you really want to mute the exception, I'd do that in the caller of the 
method, not the method itself.


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
Gerrit-Change-Number: 22037
Gerrit-PatchSet: 9
Gerrit-Owner: srs_andre <an...@softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Feb 2021 17:03:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to