pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601 )
Change subject: enb,epc: implement stdout/log KPI getter in eNB/EPC base class ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py File src/osmo_gsm_tester/obj/enb.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@368 PS1, Line 368: def get_num_phy_errors(self, kpi): > It's used in one of the TC to check for erros, like also KPI. […] Why not add this as a KPI? This way we don't need yet another API for this kind of counters. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I7c6c9abf73c2fc1d9104ea082bef6ffa0aeeac32 Gerrit-Change-Number: 22601 Gerrit-PatchSet: 3 Gerrit-Owner: srs_andre <an...@softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 17:08:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: srs_andre <an...@softwareradiosystems.com> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
