daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857 )
Change subject: pcu: Introduce several tests TC_nacc_outbound_pkt_cell_chg_notif_dup* ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857/1/pcu/PCU_Tests.ttcn@4285 PS1, Line 4285: cell_chf_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(ms.ul_tbf.tfi, req_arfcn, req_bsic); I know next to nothing of NACC but it seems to me like you could refactor the code above into a separate nacc_init function or similar. The tests in the following commit could also use it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib83eacfab7a73a2a51ab08801ff1c00c0058057c Gerrit-Change-Number: 22857 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Fri, 12 Feb 2021 14:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
