Hi Gergo, Thanks a bunch. I have a ./validate tree running which is almost done, so I will merge it shortly!
On Sun, Jan 19, 2014 at 3:12 PM, Simon Peyton Jones <simo...@microsoft.com> wrote: > Austin, I'm away now, so I think you can go ahead and merge. (I guess the > two failures below need attention though.) > > Thanks Gergo > > Simon > > | -----Original Message----- > | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Dr. > | ERDI Gergo > | Sent: 18 January 2014 13:37 > | To: Austin Seipp > | Cc: Joachim Breitner; GHC Devs > | Subject: Re: Pattern synonyms for 7.8? > | > | Hi, > | > | I've now pushed a re-based version to wip/pattern-synonyms that > | > | 1. contains a users_guide entry for -XPatternSynonyms (mostly modelled > | on > | the -XViewPatterns docs and the existing Wiki pages for > | PatternSynonyms) > | > | 2. fixes all test failures except for the following two which also > | occur > | on master: > | > | perf/should_run T5237 [stat not good enough] (normal) > | th T8633 [bad exit code] (normal) > | > | 3. adds a note to the users_guide that pattern synonym declarations > | don't > | work in GHCi. > | > | Could a native English speaker please read through the documentation > | changes on wip/pattern-synonyms? > | > | Also, I guess this is my official submission of the wip/pattern- > | synonyms > | branch for merge into master. > | > | Thanks, > | Gergo > | > | > | On Mon, 13 Jan 2014, Dr. ERDI Gergo wrote: > | > | > On Thu, 9 Jan 2014, Austin Seipp wrote: > | > > | >> 1) As Richard pointed out, the docs are under docs/users_guide, as > | >> well as the release notes. Please feel free to elaborate however you > | >> want on the feature and the bulletpoint for the release notes. > | > > | > Hope to get around to these in the weekend. > | > > | >> 2) The failures are indeed a result of your code, in particular: > | >> > | >> driver T4437 [bad stdout] (normal) > | >> generics GenDerivOutput [stderr mismatch] (normal) > | >> generics GenDerivOutput1_0 [stderr mismatch] > | (normal) > | >> generics GenDerivOutput1_1 [stderr mismatch] > | (normal) > | >> rename/should_compile T7336 [stderr mismatch] (normal) > | > > | > Fixed these. > | > > | >> 3) It seems GHCi does not support declaring pattern synonyms at the > | >> REPL. I'm not sure if it's intentional, but if it goes in like this, > | >> please be sure to document it in the release notes. We can file a > | >> ticket later for supporting pattern synonyms at the REPL. > | > > | > It's definitely not intentional and I have no idea why it would be > | so. Isn't > | > GHCi a fairly thin wrapper around the GHC internals? Is there any > | wiki page > | > detailing the differences in GHCi vs GHC code paths? > | > > | > Thanks, > | > Gergo > | > > | > | -- > | > | .--= ULLA! =-----------------. > | \ http://gergo.erdi.hu \ > | `---= ge...@erdi.hu =-------' > | Két pont között a legrövidebb út építés alatt áll. > -- Regards, Austin Seipp, Haskell Consultant Well-Typed LLP, http://www.well-typed.com/ _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
