I haven't had a chance to dig into Ben's patch yet, but I expect it will accepted soon - I don't think the change will affect performance.
Austin, would it be possible to get a relatively minor change to the event manager into 7.8.4? It may change a semi-public API under GHC.Event, but will not change any public API. What is our time window? Andi On Fri, Oct 17, 2014 at 8:34 AM, Bas van Dijk <[email protected]> wrote: > Hi Ben, Austin, > > Is there any chance of Ben's event manager patch landing in GHC-7.8.4? > > Bas > > On 13 October 2014 21:05, Ben Gamari <[email protected]> wrote: > > Ben Gamari <[email protected]> writes: > > > >> Andreas Voellmy <[email protected]> writes: > >> > >>> On Sat, Oct 11, 2014 at 12:17 PM, Ben Gamari <[email protected]> > wrote: > >>> > >>> Ah... so this is not useful to you. I guess we could add `loop` to > >>> GHC.Event's export list. On the other hand, I like your LifeTime > proposal > >>> better and then no one needs `loop`, so let's try this first. > >>> > >> I have a first cut of this here [1]. It compiles but would be I shocked > >> if it ran. All of the pieces are there but I need to change > >> EventLifetime to a more efficient encoding (there's no reason why it > >> needs to be more than an Int). > >> > > As it turns out the patch seems to get through the testsuite after a few > > minor fixes. > > > > What other tests can I subject this to? I'm afraid I don't have the > > access to any machine even close to the size of those that the original > > event manager was tested on so checking for performance regressions will > > be difficult. > > > > Cheers, > > > > - Ben > > > > _______________________________________________ > > ghc-devs mailing list > > [email protected] > > http://www.haskell.org/mailman/listinfo/ghc-devs > > >
_______________________________________________ ghc-devs mailing list [email protected] http://www.haskell.org/mailman/listinfo/ghc-devs
