Sorry about this; merged - 208a0c207c1001da0fe63e9640e2a7e0e11c4aff (I actually only built the RTS to fix that build failure... I didn't ./validate with -Wall enabled. I'm to blame here!)
On Wed, Oct 29, 2014 at 5:36 PM, Gintautas Miliauskas <[email protected]> wrote: > https://phabricator.haskell.org/D400 > > On Mon, Oct 27, 2014 at 1:34 PM, Gintautas Miliauskas > <[email protected]> wrote: >> >> FYI, after the fix ghc builds again on Windows 32-bit, but validate.sh >> fails: >> >> rts\Linker.c: In function 'allocateImageAndTrampolines': >> >> rts\Linker.c:3657:31: >> error: unused parameter 'member_name' [-Werror=unused-parameter] >> pathchar* arch_name, char* member_name, >> ^ >> cc1.exe: all warnings being treated as errors >> rts/ghc.mk:236: recipe for target 'rts/dist/build/Linker.o' failed >> >> What's the usual way to deal with this type of warning in ghc land? >> >> >> On Fri, Oct 24, 2014 at 5:37 PM, Austin Seipp <[email protected]> >> wrote: >>> >>> Gah, this slipped my mind. On it. >>> >>> On Fri, Oct 24, 2014 at 10:33 AM, Simon Marlow <[email protected]> >>> wrote: >>> > I sent a patch to Austin to validate+commit earlier this week. >>> > >>> > On 24/10/2014 15:08, Gintautas Miliauskas wrote: >>> >> >>> >> This is still not fixed, right? I've been working on the mingw gcc >>> >> upgrade and testing on 32 bit, and this failure got me running in >>> >> circles until I discovered that baseline was broken too... >>> >> >>> >> On Fri, Oct 17, 2014 at 2:00 AM, Simon Marlow <[email protected] >>> >> <mailto:[email protected]>> wrote: >>> >> >>> >> I was working on a fix yesterday but ran out of time. Frankly this >>> >> code is a nightmare, every time I touch it it breaks on some >>> >> platform - this time I validated on 64 bit Windows but not 32. >>> >> Aargh >>> >> indeed. >>> >> >>> >> On 16 Oct 2014 14:32, "Austin Seipp" <[email protected] >>> >> <mailto:[email protected]>> wrote: >>> >> >>> >> I see what's going on and am fixing it... The code broke >>> >> 32-bit >>> >> due to >>> >> #ifdefery, but I think it can be removed, perhaps (which would >>> >> be >>> >> preferable). >>> >> >>> >> On Thu, Oct 16, 2014 at 3:43 PM, Simon Peyton Jones >>> >> <[email protected] <mailto:[email protected]>> wrote: >>> >> > Simon >>> >> > >>> >> > Aargh! I think the Windows build is broken again. >>> >> > >>> >> > I think this is your commit 5300099ed >>> >> > >>> >> > Admittedly this is on a branch I’m working on, but it’s up >>> >> to >>> >> date with >>> >> > HEAD. And I have no touched Linker.c! >>> >> > >>> >> > Any ideas? >>> >> > >>> >> > Simon >>> >> > >>> >> > >>> >> > >>> >> > rts\Linker.c: In function 'allocateImageAndTrampolines': >>> >> > >>> >> > >>> >> > >>> >> > rts\Linker.c:3708:19: >>> >> > >>> >> > error: 'arch_name' undeclared (first use in this >>> >> function) >>> >> > >>> >> > >>> >> > >>> >> > rts\Linker.c:3708:19: >>> >> > >>> >> > note: each undeclared identifier is reported only once >>> >> for each >>> >> > function it appears in >>> >> > >>> >> > rts/ghc.mk:236 <http://ghc.mk:236>: recipe for target >>> >> 'rts/dist/build/Linker.o' failed >>> >> > >>> >> > make[1]: *** [rts/dist/build/Linker.o] Error 1 >>> >> > >>> >> > make[1]: *** Waiting for unfinished jobs.... >>> >> > >>> >> > >>> >> > _______________________________________________ >>> >> > ghc-devs mailing list >>> >> > [email protected] <mailto:[email protected]> >>> >> > http://www.haskell.org/mailman/listinfo/ghc-devs >>> >> > >>> >> >>> >> >>> >> >>> >> -- >>> >> Regards, >>> >> >>> >> Austin Seipp, Haskell Consultant >>> >> Well-Typed LLP, http://www.well-typed.com/ >>> >> >>> >> >>> >> _______________________________________________ >>> >> ghc-devs mailing list >>> >> [email protected] <mailto:[email protected]> >>> >> http://www.haskell.org/mailman/listinfo/ghc-devs >>> >> >>> >> >>> >> >>> >> >>> >> -- >>> >> Gintautas Miliauskas >>> > >>> > _______________________________________________ >>> > ghc-devs mailing list >>> > [email protected] >>> > http://www.haskell.org/mailman/listinfo/ghc-devs >>> >>> >>> >>> -- >>> Regards, >>> >>> Austin Seipp, Haskell Consultant >>> Well-Typed LLP, http://www.well-typed.com/ >> >> >> >> >> -- >> Gintautas Miliauskas > > > > > -- > Gintautas Miliauskas -- Regards, Austin Seipp, Haskell Consultant Well-Typed LLP, http://www.well-typed.com/ _______________________________________________ ghc-devs mailing list [email protected] http://www.haskell.org/mailman/listinfo/ghc-devs
