Yes thanks Doug… testing now From: loneti...@gmail.com [mailto:loneti...@gmail.com] Sent: 08 February 2018 00:17 To: Douglas Wilson <douglas.wil...@gmail.com>; Simon Peyton Jones <simo...@microsoft.com> Cc: ghc-devs <ghc-devs@haskell.org> Subject: RE: Windows build broken -- help!
I’ve pushed the commit. Thanks Doug! From: Douglas Wilson<mailto:douglas.wil...@gmail.com> Sent: Wednesday, February 7, 2018 23:33 To: Simon Peyton Jones<mailto:simo...@microsoft.com> Cc: ghc-devs<mailto:ghc-devs@haskell.org> Subject: Re: Windows build broken -- help! Hi Simon, The first patch you quoted half-fixed this. the patch here: https://phabricator.haskell.org/D4392 should fix whole-fix it. (It at least validates green on windows) On Thu, Feb 8, 2018 at 12:18 PM, Simon Peyton Jones via ghc-devs <ghc-devs@haskell.org<mailto:ghc-devs@haskell.org>> wrote: PS Presumably it’s these commits commit 00f1a4ab80b201ce15c509126f89c5a108786f32 Author: Douglas Wilson <douglas.wil...@gmail.com<mailto:douglas.wil...@gmail.com>> Date: Tue Feb 6 17:27:32 2018 -0500 rts: fix some barf format specifiers. Reviewers: bgamari, erikd, simonmar Reviewed By: bgamari Subscribers: rwbarton, thomie, carter Differential Revision: https://phabricator.haskell.org/D4390 commit 4d1c3b72ec27c8e51fb40809bba3ce35246a2966 Author: Ben Gamari <bgamari.f...@gmail.com<mailto:bgamari.f...@gmail.com>> Date: Tue Feb 6 13:27:35 2018 -0500 rts: Add format attribute to barf Test Plan: Validate Reviewers: erikd, simonmar Reviewed By: simonmar Subscribers: rwbarton, thomie, carter Differential Revision: https://phabricator.haskell.org/D4374 From: ghc-devs [mailto:ghc-devs-boun...@haskell.org<mailto:ghc-devs-boun...@haskell.org>] On Behalf Of Simon Peyton Jones via ghc-devs Sent: 07 February 2018 23:14 To: ghc-devs <ghc-devs@haskell.org<mailto:ghc-devs@haskell.org>>; Phyx <loneti...@gmail.com<mailto:loneti...@gmail.com>> Subject: Windows build broken -- help! Aargh. Windows build is broken again. Log below. Help! Simon "inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -optc-Werror -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith -optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Wundef -optc-Iincludes -optc-Iincludes/dist -optc-Iincludes/dist-derivedconstants/header -optc-Iincludes/dist-ghcconstants/header -optc-Irts -optc-Irts/dist/build -optc-DCOMPILING_RTS -optc-fno-strict-aliasing -optc-fno-common -optc-Irts/dist/build/./autogen -optc-Wno-error=inline -optc-O2 -optc-fomit-frame-pointer -optc-g -optc-DRtsWay=\"rts_v\" -optc-DWINVER=0x06000100 -static -O0 -H64m -Wall -fllvm-fill-undef-with-garbage -Werror -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header -Irts -Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint -i -irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen -Irts/dist/build/./autogen -O2 -Wcpp-undef -Wnoncanonical-monad-instances -c rts/StgPrimFloat.c -o rts/dist/build/StgPrimFloat.o rts\Schedule.c:274:14: error: error: unknown conversion type character 'l' in format [-Werror=format=] barf("sched_state: %" FMT_Word, sched_state); ^~~~~~~~~~~~~~~~ | 274 | barf("sched_state: %" FMT_Word, sched_state); | ^ In file included from C:/code/HEAD-1/inplace/mingw/x86_64-w64-mingw32/include/stdio.h:1036:0, from includes/rts/Flags.h:16, from includes/Rts.h:191, from rts\Schedule.c:11:0: error: C:/code/HEAD-1/inplace/mingw/x86_64-w64-mingw32/include/_mingw_print_pop.h:86:18: note: format string is defined here #define PRIu64 "llu" ^ rts\Schedule.c:274:14: error: error: too many arguments for format [-Werror=format-extra-args] barf("sched_state: %" FMT_Word, sched_state); ^~~~~~~~~~~~~~~~ | 274 | barf("sched_state: %" FMT_Word, sched_state); | ^ cc1.exe: all warnings being treated as errors `gcc.exe' failed in phase `C Compiler'. (Exit code: 1) "inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -optc-Werror -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith -optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Wundef -optc-Iincludes -optc-Iincludes/dist -optc-Iincludes/dist-derivedconstants/header -optc-Iincludes/dist-ghcconstants/header -optc-Irts -optc-Irts/dist/build -optc-DCOMPILING_RTS -optc-fno-strict-aliasing -optc-fno-common -optc-Irts/dist/build/./autogen -optc-Wno-error=inline -optc-O2 -optc-fomit-frame-pointer -optc-g -optc-DRtsWay=\"rts_v\" -optc-DWINVER=0x06000100 -static -O0 -H64m -Wall -fllvm-fill-undef-with-garbage -Werror -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header -Irts -Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint -i -irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen -Irts/dist/build/./autogen -O2 -Wcpp-undef -Wnoncanonical-monad-instances -c rts/Profiling.c -o rts/dist/build/Profiling.o make[1]: *** [rts/ghc.mk:295<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.mk%3A295&data=04%7C01%7Csimonpj%40microsoft.com%7C526668e88100442c6fd908d56e894596%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636536458221776643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=3BD1d%2FQHC001uGrGhb5rxMR7Aqkz9titiKh9w%2F1AiYE%3D&reserved=0>: rts/dist/build/Schedule.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:127: all] Error 2 /c/code/HEAD-1$ _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org<mailto:ghc-devs@haskell.org> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&data=04%7C01%7Csimonpj%40microsoft.com%7C526668e88100442c6fd908d56e894596%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636536458221776643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=I0%2FpbgsPgbARmGgXKki1Jz9pJeUMfKhQv9KNrWIyCT0%3D&reserved=0>
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
