I'm on Firefox. It doesn't matter all that much, really. I was hoping that a review was its own thing. But GitLab doesn't do that: a review is just a set of comments all delivered at the same time. Now that I've posted my review, my comments have become 49 separate "discussions". Oof.
Richard > On Jan 4, 2019, at 1:09 PM, Ben Gamari <b...@smart-cactus.org> wrote: > > Richard Eisenberg <r...@cs.brynmawr.edu> writes: > >> PSA: When reviewing an MR on GitLab, every comment has two buttons: >> (1) add to review, and (2) add comment now. Cmd+Enter (on my machine >> at least), does option (2), even though option (1) is bold and green. >> This is not what I wanted. (By the way, "comments" actually open these >> things called "discussions", which can be resolved. But that's another >> matter.) >> > Hmm, strange. I can't seem to reproduce this. Which browser are you > using? > > Cheers, > > - Ben > _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
