(apologies to Tristan for extra copy; meant to reply to list) On Thu, 2013-12-26 at 16:34 +0100, [email protected] wrote: > Hello, > > > As Tristan has been busy, I checked out the testsuite and tried it... > > > > First observations... > > > > I noticed one "SKIPPED" test in the "gna" tests : > > testsuite/gna/sr3028/testsuite.sh > > It seems to be a good candidate for "analyze_failure" which does the > > expected thing for me. Patched, but if there's a good reason for the > > way > > it was, I'll un-patch... > > Fine with me. > I plan to rewrite the fix for this issue, because I think it doesn't > catch all the possible cases. > > > Then I see one failure in the VESTS testsuite as it stands from the > > commit: > > > > Test: 368 vhdl-93/ashenden/compliant/ch_13_fg_13_26.vhd > > ghdl -a --std=93c vhdl-93/ashenden/compliant/ch_13_fg_13_26.vhd > > vhdl-93/ashenden/compliant/ch_13_fg_13_26.vhd:33:20: port "a" already > > associated in primary binding > > (and three similar offences) > > ghdl: compilation error > > > > I don't know what to make of this : can anyone confirm, is it a > > regression from my recent updates?(doesn't look like anything I > > changed > > but you never know) or does it fail with previous revisions? > > I tested with ghdl_mcode, and not with ghdl_gcc... > > > > Commented out in > > testsuite/vests/vhdl-93/ashenden/compliant/compliant.exp > > and the testsuite runs to completion... > > > > Then I modified the vests/testsuite.sh script to actually elaborate > > and > > run the tests (for those specified as run_compliant_test). This uses > > a > > little program to extract any top-level entity names from a VHDL > > file. > > To build it: > > gnatmake get_entities.adb > > Great! > > > I am now coming to the conclusion that the Clifton Labs tests were > > never > > actually run... on any simulator! First bits of evidence below... > > I agree. There are several errors. > > > ----------------------------------------------------------------------------------------------- > > > > Test: 10 > > vhdl-93/clifton-labs/compliant/functional/attributes/signal/simple-event-attribute.vhdl > > ... > > ghdl -r test --assert-level=error > > vhdl-93/clifton-labs/compliant/functional/attributes/signal/simple-event-attribute.vhdl:18:5:@36ns:(assertion > > failure): TEST FAILED - 'event not tripped > > ./test:error: assertion failed > > ./test:error: simulation failed > > ghdl: compilation error > > > > from (condensed source) > > ------------------------- > > s <= '1' after 10 ns, '0' after 20 ns, '1' after 30 ns, '0' after > > 40 > > ns; > > p: process > > begin > > wait for 1 ns; > > wait for 25 ns; > > wait for 10 ns; > > assert (s'event) report "TEST FAILED - 'event not tripped" > > severity > > failure; > > ------------------------- > > which SHOULD assert, as the Waits don't add up to any of the events > > on > > s! Change the last wait to 4 ns and s'event IS raised : test pass. > > Ok. > > > ----------------------------------------------------------------------------------------------- > > > > Test: 60 > > vhdl-93/clifton-labs/compliant/functional/statements/block-statements/simple-grouping-block.vhdl > > ... > > ghdl -r test --assert-level=error > > vhdl-93/clifton-labs/compliant/functional/statements/block-statements/simple-grouping-block.vhdl:23:7:@1ns:(assertion > > failure): TEST PASSED > > ./test:error: assertion failed > > ./test:error: simulation failed > > ghdl: compilation error > > > > Source : failing line is > > assert not(now = 1 ns) report "TEST PASSED" severity FAILURE; > > Modified to : > > assert not(now = 1 ns) report "TEST PASSED" severity WARNING; > > passes > > :-) > > > ----------------------------------------------------------------------------------------------- > > This next one (second version) may actually be a ghdl failure ... > > comments welcome > > ----------------------------------------------------------------------------------------------- > > > > > > Test: 71 > > vhdl-93/clifton-labs/compliant/functional/textio/read/character_array_read.vhdl > > ... > > ghdl -r character_array_read --assert-level=error > > ./character_array_read:error: open: cannot open file > > character_array_read.in > > ghdl: compilation error > > > > This fails because we are executing in the wrong place (where the > > input > > files aren't!). For now I just copy the .in files! > > > > Test: 71 > > vhdl-93/clifton-labs/compliant/functional/textio/read/character_array_read.vhdl > > ... > > ghdl -r character_array_read --assert-level=error > > ./character_array_read:internal error: file: IO error > > ghdl: compilation error > > The format of binary files is not defined by the standard. We should use the > output of a previous write. > > > I see a fair few tests commented out in there already. > > (I also see that Tristan has already fixed analysis for three of > > them! > > The last, dynamic_package_procedure_for_loop.vhdl, now fails at > > runtime) > > My fault. Fix in progress. > > Thanks, > Tristan.
_______________________________________________ Ghdl-discuss mailing list [email protected] https://mail.gna.org/listinfo/ghdl-discuss
