[
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100901#comment-13100901
]
Jake Mannix commented on GIRAPH-27:
-----------------------------------
Awesome, thanks Avery. Looks good to me.
In looking over the diff in more detail in reviewboard, I notice that there are
still a bunch of places where Vertex is referred to, but really BasicVertex (or
at most MutableVertex) is all that's needed. But I'll open another ticket for
those changes once this has been merged in.
> Mutable static global state in Vertex.java should be refactored
> ---------------------------------------------------------------
>
> Key: GIRAPH-27
> URL: https://issues.apache.org/jira/browse/GIRAPH-27
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Jake Mannix
> Assignee: Jake Mannix
> Attachments: GIRAPH-27.patch, GIRAPH-27.patch
>
>
> Vertex.java has a bunch of static methods for getting/setting global graph
> state (total number of vertices, edges, a reference to the GraphMapper, etc).
> Refactoring this into a GraphState object, which every Vertex can hold onto
> a reference to (yes, a tiny bit more memory per Vertex, but in comparison to
> what's already in there...)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
