[
https://issues.apache.org/jira/browse/GIRAPH-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103798#comment-13103798
]
Jake Mannix commented on GIRAPH-31:
-----------------------------------
+1 to that, given your argument on the current use of the class. It may come a
time when we have generic things going on in GraphMapper or BspServiceWorker
which need to do special optimized things to sorted vertices, and at that time
we can add an "isSorted()" or "getSortedIterator()" method.
> Hide the SortedMap<I, Edge<I,E>> in Vertex from client visibility (impl.
> detail), replace with appropriate accessor methods
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-31
> URL: https://issues.apache.org/jira/browse/GIRAPH-31
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Jake Mannix
> Assignee: Jake Mannix
> Attachments: GIRAPH-31.diff
>
>
> As discussed on the list, and on GIRAPH-28, the SortedMap<I, Edge<I,E>> is an
> implementation detail which needs not be exposed to application developers -
> they need to iterate over the edges, and possibly access them one-by-one, and
> remove them (in the Mutable case), but they don't need the SortedMap, and
> creating primitive-optimized BasicVertex implementations is hampered by the
> fact that clients expect this Map to exist.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
