[ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147972#comment-13147972 ]
Jake Mannix commented on GIRAPH-74: ----------------------------------- But my concern is regarding how this works with general BSP algorithm correctness: if you can vote to halt, then later cancel it, can this lead to problems, or is this generally allowed? > GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex > --------------------------------------------------------------------------- > > Key: GIRAPH-74 > URL: https://issues.apache.org/jira/browse/GIRAPH-74 > Project: Giraph > Issue Type: Bug > Components: graph > Affects Versions: 0.70.0 > Reporter: Claudio Martella > Assignee: Claudio Martella > Fix For: 0.70.0 > > Attachments: GIRAPH-36-cleaup.diff > > > After GIRAPH-36, in a couple of places Vertex was left instead of > BasicVertex. To achieve the fix a BasicVertex was extended with a new boolean > isHalted(boolean state) method that totally hides boolean halt field. I > believe this unifies the voteToHalt() and isHalted() methods totally hiding > the halting management of Vertices (before it was relying on the existence of > boolean halt field). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira