[
https://issues.apache.org/jira/browse/GIRAPH-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149805#comment-13149805
]
Jakob Homan commented on GIRAPH-51:
-----------------------------------
Looks great. A few comments:
* It may make sense to move InternalVertexRunner to the src tree rather than
test tree, since it's a user-facing class rather than something for Giraph's
internal testing. I can imagine us generating a separate test jar soon and
we'd want this class in the regular jar we ship to end users.
* Is it necessary to specify the input and output formats and to write data out
to the file system? In general a vertex implementation should be able to work
with reasonable vertices from any input source (part of the GIRAPH-64 work). If
the internal vertex runner just fed the values into the compute method we'd
save file io and coupling of specific formats.
* Can you add javadoc for the public methods?
* It looks like the ZooKeeper exceptions are probably race conditions. I see
similar ones during regular test execution. It would be nice to remove the
need for ZooKeeper on these types of tests: if one is spinning up ZK, it's not
really a unit test any more, and it should be possible to test vertex
implementations without it. One should be able to just feed input state
(vertices, edges, superstep #, etc.) and verify the output state without every
actually spinning up any of the distributed infrastructure. But that's
probably best done in another JIRA. I don't think the ZK exceptions are
something to be concerned about.
> Provide unit testing tool for Giraph algorithms
> -----------------------------------------------
>
> Key: GIRAPH-51
> URL: https://issues.apache.org/jira/browse/GIRAPH-51
> Project: Giraph
> Issue Type: Improvement
> Reporter: Jakob Homan
> Attachments: GIRAPH-51.patch
>
>
> It would be nice to have a little tool, similar to MRUnit, that would allow
> Giraph application writers to quickly unit test their algorithms. The tool
> could take a Vertex implementation, a set of input and expected output and
> verify that after the specified number of supersteps, we've gotten what we
> expect.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
