----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2885/#review3375 -----------------------------------------------------------
Ship it! Yep, looks good to me. Note to committers: how does it work in these situations? Shall I just commit this or should I +1 and wait for another one? - Claudio On 2011-11-20 02:40:35, shaunak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2885/ > ----------------------------------------------------------- > > (Updated 2011-11-20 02:40:35) > > > Review request for giraph. > > > Summary > ------- > > Simplifying boolean expression using ternary operation. > > > This addresses bug GIRAPH-84. > https://issues.apache.org/jira/browse/GIRAPH-84 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspRecordReader.java > 1204113 > > Diff: https://reviews.apache.org/r/2885/diff > > > Testing > ------- > > $ mvn test > > > Thanks, > > shaunak > >
