[ https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181522#comment-13181522 ]
Jakob Homan commented on GIRAPH-119: ------------------------------------ +1. The change log isn't usually modified as part of the patch, but as part of the commit, although I don't see a reason it would hurt, except perhaps conflicts in the file? > VertexCombiner should work on Iterable<M> instead of List<M> > ------------------------------------------------------------ > > Key: GIRAPH-119 > URL: https://issues.apache.org/jira/browse/GIRAPH-119 > Project: Giraph > Issue Type: Improvement > Components: graph > Affects Versions: 0.70.0 > Reporter: Claudio Martella > Assignee: Claudio Martella > Attachments: GIRAPH-119.diff > > > Currently VertexCombiner expects a List<M>. It should be refactored to > Iterable<M> to sync with Iterable-based BasicVertex messages logics. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira