[ https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188572#comment-13188572 ]
Jakob Homan commented on GIRAPH-126: ------------------------------------ Looks good except for the introduction of two new empty lines. Andre, can you remove these and upload a new patch? I'll commit that. Thanks. > Use Collections.emptyList() in BasicRPCCommunications.java > ---------------------------------------------------------- > > Key: GIRAPH-126 > URL: https://issues.apache.org/jira/browse/GIRAPH-126 > Project: Giraph > Issue Type: Improvement > Reporter: André Kelpe > Priority: Minor > Attachments: GIRAPH-126.patch > > > I am doing some tests with giraph and I am having some memory problems. While > I was browsing through the codebase I saw that you are allocating a new > ArrayList (which has an underlying array of 10 elements) for each Vertex, > that has no Messages to be delivered. That's a waste of memory and time. This > patch replaces it with the EMPTY_LIST of the Collections utility class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira