[ 
https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203900#comment-13203900
 ] 

Avery Ching commented on GIRAPH-139:
------------------------------------

I agree the main() and run() code should be deprecated, but preferably after 
giraph-examples.jar is ready =).  
                
> Change PageRankBenchmark to be accessible via bin/giraph
> --------------------------------------------------------
>
>                 Key: GIRAPH-139
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-139
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-139.patch
>
>
> Currently the PageRankBenchmark has its own main and tool implementation and 
> is difficult to access from the bin/giraph script.  It would be better if 
> everything were accessible via bin/giraph.  The benchmark is particularly 
> problematic because it uses inner classes for its two actual Vertex 
> implementations, which have to be specified on the command line as their 
> .class name(ie 
> org.apache.giraph.benchmark.PageRankBenchmark$PageRankHashMapVertex) rather 
> than just with dots, as one would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to