[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208731#comment-13208731 ]
Jakob Homan commented on GIRAPH-40: ----------------------------------- ok, looks good to me. +1. However, since no one can do a full review of this patch, I'd like another committer to +1 it as well before committing. This helps us to explain away not actually doing a full review. > Adding checkstyle enforcement of Giraph code conventions > -------------------------------------------------------- > > Key: GIRAPH-40 > URL: https://issues.apache.org/jira/browse/GIRAPH-40 > Project: Giraph > Issue Type: New Feature > Reporter: Avery Ching > Assignee: Avery Ching > Priority: Minor > Attachments: GIRAPH-40.2.patch, GIRAPH-40.patch, GIRAPH-40.patch > > > Now that we have some code conventions (see GIRAPH-21), we should enforce > them with a maven checkstyle plugin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira