[ 
https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216047#comment-13216047
 ] 

Avery Ching commented on GIRAPH-85:
-----------------------------------

please make sure it passes 'mvn verify' as well.  That will check rat and 
checkstyle.
                
> Simplify return expression in RPCCommunications::getRPCProxy
> ------------------------------------------------------------
>
>                 Key: GIRAPH-85
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-85
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>              Labels: newbie
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-85.patch
>
>
> Twice in RPCCommunications::getRPCProxy a local variable, proxy, is created 
> and immediately returned.  We can simplify this to just return the value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to