[ https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216368#comment-13216368 ]
Hudson commented on GIRAPH-87: ------------------------------ Integrated in Giraph-trunk-Commit #85 (See [https://builds.apache.org/job/Giraph-trunk-Commit/85/]) GIRAPH-87: Simplify boolean expression in BspService::checkpointFrequencyMet (Eli Reisman via aching). (Revision 1293545) Result = SUCCESS aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293545 Files : * /incubator/giraph/trunk/CHANGELOG * /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java > Simplify boolean expression in BspService::checkpointFrequencyMet > ----------------------------------------------------------------- > > Key: GIRAPH-87 > URL: https://issues.apache.org/jira/browse/GIRAPH-87 > Project: Giraph > Issue Type: Improvement > Affects Versions: 0.2.0 > Reporter: Jakob Homan > Assignee: Eli Reisman > Labels: newbie > Attachments: GIRAPH-87.patch, GIRAPH-87.patch > > > {noformat} if (superstep < firstCheckpoint) { > return false; > } else if (((superstep - firstCheckpoint) % checkpointFrequency) == > 0) { > return true; > } else { > return false; > }{noformat} > can be simplified to just return the result of the else if evaluation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira