[
https://issues.apache.org/jira/browse/GIRAPH-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232014#comment-13232014
]
Avery Ching commented on GIRAPH-156:
------------------------------------
+1, looks good. It would be great if you could wrap LOG.info with if
(LOG.isInfoEnabled()), before committing. There are some other places in this
file as well without the LOG enabled wrap. You can either make that change
here or someone else can do it in another patch.
> Users should be able to set simple 'custom arguments' via
> org.apache.giraph.GiraphRunner
> ----------------------------------------------------------------------------------------
>
> Key: GIRAPH-156
> URL: https://issues.apache.org/jira/browse/GIRAPH-156
> Project: Giraph
> Issue Type: Improvement
> Components: conf and scripts
> Affects Versions: 0.1.0
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Attachments: GIRAPH-156-1.patch, GIRAPH-156.patch
>
>
> Some vertices need custom arguments to run. The SimpleShortestPathsVertex for
> example needs to know the source vertex for the computation which is saved in
> the job's Configuration as _SimpleShortestPathsVertex.sourceId_. Users should
> be able to apply such simple custom arguments via GiraphRunner.
> I propose to add a new option _--customArguments_ where users can supply
> arguments in the form _<param1>=<value1>,<param2>=<value2>_ for this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
