[ https://issues.apache.org/jira/browse/GIRAPH-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248571#comment-13248571 ]
Avery Ching commented on GIRAPH-168: ------------------------------------ Eugene, can you also please update the README with your changes? I was able to apply your patch, but ran into the following error: vn verify -DskipTests -Dhadoop=facebook -Dhadoop.jar.path=/Users/aching/Avery/FacebookJars/hadoop-0.20-core.jar [INFO] Scanning for projects... [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Apache Incubator Giraph 0.2-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-maven) @ giraph --- [INFO] [INFO] --- munge-maven-plugin:1.0:munge (munge) @ giraph --- [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1.225s [INFO] Finished at: Fri Apr 06 11:21:29 PDT 2012 [INFO] Final Memory: 6M/81M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.sonatype.plugins:munge-maven-plugin:1.0:munge (munge) on project giraph: The parameters 'symbols' for goal org.sonatype.plugins:munge-maven-plugin:1.0:munge are missing or invalid -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginParameterException > Simplify munge directive usage with new munge flag HADOOP_SECURE (rather than > HADOOP_FACEBOOK) and remove usage of HADOOP > ------------------------------------------------------------------------------------------------------------------------- > > Key: GIRAPH-168 > URL: https://issues.apache.org/jira/browse/GIRAPH-168 > Project: Giraph > Issue Type: Improvement > Affects Versions: 0.2.0 > Reporter: Eugene Koontz > Assignee: Eugene Koontz > Attachments: GIRAPH-168.patch, GIRAPH-168.patch, GIRAPH-168.patch, > GIRAPH-168.patch > > > This JIRA relates to the mail thread here: > http://mail-archives.apache.org/mod_mbox/incubator-giraph-dev/201203.mbox/browser > Currently we check for the munge flags HADOOP, HADOOP_FACEBOOK and > HADOOP_NON_SECURE when using munge in a few places. Hopefully we can > eliminate usage of munge in the future, but until then, we can mitigate the > complexity by consolidating the number of flags checked. This JIRA renames > HADOOP_FACEBOOK to HADOOP_SECURE, and removes usages of HADOOP, to handle the > same conditional compilation requirements. It also makes it easier to add > more maven profiles so that we can easily increase our hadoop version > coverage. > This patch modifies the existing hadoop_facebook profile to use the new > HADOOP_SECURE munge flag, rather than HADOOP_FACEBOOK. > It also adds a new hadoop maven profile, hadoop_trunk, which also sets > HADOOP_SECURE. > Finally, it adds a default profile, hadoop_0.20.203. This is needed so that > we can specify its dependencies separately from hadoop_trunk, because the > hadoop dependencies have changed between trunk and 0.205.0 - the former > requires hadoop-common, hadoop-mapreduce-client-core, and > hadoop-mapreduce-client-common, whereas the latter requires hadoop-core. > With this patch, the following passes: > {code} > mvn clean verify && mvn -Phadoop_trunk clean verify && mvn -Phadoop_0.20.203 > clean verify > {code} > Current problems: > * I left in place the usage of HADOOP_NON_SECURE, but note that the profile > that uses this is hadoop_non_secure, which fails to compile on trunk: > https://issues.apache.org/jira/browse/GIRAPH-167 . > * I couldn't get -Phadoop_facebook to work; does this work outside of > Facebook? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira