Re: [PATCH] backward compat for 5.005_03 (Re: libwww-perl-5.61)

[Gisle Aas]

Tatsuhiko Miyagawa <[EMAIL PROTECTED]> writes:

> t/live/acrivestate.t fails in 5.005_03.
> 
> --- libwww-perl-5.61.orig/lib/Net/HTTP/Methods.pm     Sat Nov 17 14:24:58 2001
> +++ libwww-perl-5.61/lib/Net/HTTP/Methods.pm  Sat Nov 17 14:32:31 2001
> @@ -163,7 +163,7 @@
>  
>  sub write_request {
>      my $self = shift;
> -    $self->syswrite($self->format_request(@_));
> +    syswrite $self, $self->format_request(@_);
>  }

For me it fails in the connect() call.  Why should this patch make a
difference?

The IO::Handle that comes with perl5.005_03 has a syswrite method that
require you to send the length as the second argument.  That means we
might have to do something like:

sub write_request {
     my $self = shift;
     my $req_data = $self->format_request(@_);
     $self->syswrite($req_data, length($req_data));
}

but then it should probably test the outcome of the syswrite call as well.
I think it might be better to simply make it:

sub write_request {
     my $self = shift;
     $self->print($self->format_request(@_));
}

Still need to figure out why connect fails for me on this test with
perl5.005 ...

Regards,
Gisle