stefan pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=3a11868201344c3c79719269a4cebd375b3c3872
commit 3a11868201344c3c79719269a4cebd375b3c3872
Author: Stefan Schmidt <ste...@osg.samsung.com>
Date: Mon Nov 30 17:22:42 2015 +0100
evas_3d_utils: do not bitwise AND against 0 in condition
We need to check against the state here and if the compilers assignes 0 to
the
first item in an enum we are screwed here as the bitwise AND will always
evaluate to false.
This is a re-incarnation from a486671bce76e405a8d7261f19b0f67ca678f0c4
---
src/lib/evas/include/evas_3d_utils.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/lib/evas/include/evas_3d_utils.h
b/src/lib/evas/include/evas_3d_utils.h
index 10192cc..52a9511 100644
--- a/src/lib/evas/include/evas_3d_utils.h
+++ b/src/lib/evas/include/evas_3d_utils.h
@@ -349,7 +349,7 @@ evas_vec3_transform(Evas_Vec3 *out, const Evas_Vec3 *v,
const Eina_Matrix3 *m)
{
Evas_Vec3 tmp;
- if (eina_matrix3_type_get(m) & EINA_MATRIX_TYPE_IDENTITY)
+ if (eina_matrix3_type_get(m) == EINA_MATRIX_TYPE_IDENTITY)
{
evas_vec3_copy(out, v);
return;
@@ -367,7 +367,7 @@ evas_vec3_homogeneous_position_transform(Evas_Vec3 *out,
const Evas_Vec3 *v, con
{
Evas_Vec3 tmp;
- if (eina_matrix4_type_get(m) & EINA_MATRIX_TYPE_IDENTITY)
+ if (eina_matrix4_type_get(m) == EINA_MATRIX_TYPE_IDENTITY)
{
evas_vec3_copy(out, v);
return;
@@ -386,7 +386,7 @@ evas_vec3_homogeneous_direction_transform(Evas_Vec3 *out,
const Evas_Vec3 *v, co
{
Evas_Vec3 tmp;
- if (eina_matrix4_type_get(m) & EINA_MATRIX_TYPE_IDENTITY)
+ if (eina_matrix4_type_get(m) == EINA_MATRIX_TYPE_IDENTITY)
{
evas_vec3_copy(out, v);
return;
@@ -564,7 +564,7 @@ evas_vec4_transform(Evas_Vec4 *out, const Evas_Vec4 *v,
const Eina_Matrix4 *m)
{
Evas_Vec4 tmp;
- if (eina_matrix4_type_get(m) & EINA_MATRIX_TYPE_IDENTITY)
+ if (eina_matrix4_type_get(m) == EINA_MATRIX_TYPE_IDENTITY)
{
evas_vec4_copy(out, v);
return;
--
