raster pushed a commit to branch elementary-1.13.
http://git.enlightenment.org/core/elementary.git/commit/?id=8b8eb61bde425ec8c7443845445f22b91f840a70
commit 8b8eb61bde425ec8c7443845445f22b91f840a70
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date: Thu Mar 10 18:29:22 2016 +0900
elm - genlist item - index get start from 0 - unbreak api break
so in feb 2015 seoz changed elm_genlist_item_index_get to start from 1
rather than 0. going back to elm code in 1.7 - it started at 0. this
is an api break that shouldn't have happend, but did. this fixes that.
yes - it's inconsistent with gengrid's index_get - but gengrid here is
wrong. nth_get starts at 0. this will get fixed with eo api's, and in
fact none of these index/nth api's should be in genlist's eo api.
legacy only. i can see why this was changed - it matches gengrid and
is more consistent, but we can't break things even if stupid.
@fix
---
src/lib/elm_genlist.c | 2 +-
src/lib/elm_genlist_item.eo | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index e556876..8d263c4 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -7062,7 +7062,7 @@ elm_genlist_item_cursor_engine_only_get(const
Elm_Object_Item *eo_it)
EOLIAN static int
_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it)
{
- int cnt = 1;
+ int cnt = 0;
Elm_Gen_Item *tmp;
ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1);
diff --git a/src/lib/elm_genlist_item.eo b/src/lib/elm_genlist_item.eo
index 34a6179..fdfb6e5 100644
--- a/src/lib/elm_genlist_item.eo
+++ b/src/lib/elm_genlist_item.eo
@@ -169,7 +169,7 @@ class Elm_Genlist_Item(Elm_Widget_Item)
/*@
Get the index of the item. It is only valid once
displayed.
- The index start from 1.
+ The index start from 0.
@ingroup Genlist
*/
--
