devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=12947e01e89efc2a1e5fb4e044e798955f59af13

commit 12947e01e89efc2a1e5fb4e044e798955f59af13
Author: Chris Michael <cp.mich...@samsung.com>
Date:   Mon Nov 6 10:17:29 2017 -0500

    evas-object-main: Fix potential null dereference
    
    Coverity reports that EVAS_OBJECT_DATA_SAFE_GET returns NULL here (184
    out of 188 times). As such, we should not be calling
    _event_animation_object_get with a null object so add a null check here.
    
    Fixes Coverity CID1381713
    
    @fix
    
    Signed-off-by: Chris Michael <cp.mich...@samsung.com>
---
 src/lib/evas/canvas/evas_object_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/evas/canvas/evas_object_main.c 
b/src/lib/evas/canvas/evas_object_main.c
index dce4954e08..57f8dd7bc7 100644
--- a/src/lib/evas/canvas/evas_object_main.c
+++ b/src/lib/evas/canvas/evas_object_main.c
@@ -2829,6 +2829,8 @@ _efl_canvas_object_event_animation_is_running(Eo *eo_obj,
 {
    Evas_Object_Protected_Data *obj = EVAS_OBJECT_DATA_SAFE_GET(eo_obj);
 
+   if (!obj) return EINA_FALSE;
+
    if (_event_animation_object_get(obj, desc))
      return EINA_TRUE;
 

-- 


Reply via email to