bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a69392e8380526c4adc2adf4a156415e5b1dca4e

commit a69392e8380526c4adc2adf4a156415e5b1dca4e
Author: Radoslaw Cybulski <r.cybul...@partner.samsung.com>
Date:   Tue Apr 30 11:59:53 2019 +0000

    Fix for invalid ATSPI role on naviframe page element
    
    ATSPI role page_tab was set on invalid object and thus ignored.
    
    Reviewed-by: Marcel Hollerbach <m...@marcel-hollerbach.de>
    Differential Revision: https://phab.enlightenment.org/D8789
---
 src/lib/elementary/elc_naviframe.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/lib/elementary/elc_naviframe.c 
b/src/lib/elementary/elc_naviframe.c
index fa22902d90..7675b6103b 100644
--- a/src/lib/elementary/elc_naviframe.c
+++ b/src/lib/elementary/elc_naviframe.c
@@ -1283,8 +1283,6 @@ _item_new(Evas_Object *obj,
    ELM_NAVIFRAME_DATA_GET(obj, sd);
 
    eo_item = efl_add(ELM_NAVIFRAME_ITEM_CLASS, obj);
-   efl_access_object_role_set(eo_item, EFL_ACCESS_ROLE_PAGE_TAB);
-   efl_access_object_i18n_name_set(eo_item, (char*)title_label);
 
    if (!eo_item)
      {
@@ -1295,9 +1293,13 @@ _item_new(Evas_Object *obj,
    ELM_NAVIFRAME_ITEM_DATA_GET(eo_item, it);
 
    //item base layout
-   VIEW_SET(it, elm_layout_add(obj));
+   Eo *elem = elm_layout_add(obj);
+   VIEW_SET(it, elem);
    evas_object_smart_member_add(VIEW(it), obj);
 
+   efl_access_object_role_set(elem, EFL_ACCESS_ROLE_PAGE_TAB);
+   efl_access_object_i18n_name_set(elem, (char*)title_label);
+
    if (!elm_widget_sub_object_add(obj, VIEW(it)))
      ERR("could not add %p as sub object of %p", VIEW(it), obj);
 

-- 


Reply via email to