[EGIT] [core/efl] master 02/02: elc_fileselector: add NULL check for eina_value_type_get

[Yeongjong Lee]

zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b7db2edeeca402a4999b3d3a3807ec7f2ce8bc0d

commit b7db2edeeca402a4999b3d3a3807ec7f2ce8bc0d
Author: Yeongjong Lee <yj34....@samsung.com>
Date:   Wed Feb 12 09:05:42 2020 -0500

    elc_fileselector: add NULL check for eina_value_type_get
    
    Reviewers: Jaehyun_Cho, Hermet, zmike
    
    Reviewed By: zmike
    
    Subscribers: zmike, cedric, #reviewers, #committers
    
    Tags: #efl
    
    Differential Revision: https://phab.enlightenment.org/D11314
---
 src/lib/elementary/elc_fileselector.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/lib/elementary/elc_fileselector.c 
b/src/lib/elementary/elc_fileselector.c
index 39f1a7cd3d..eb107b14c6 100644
--- a/src/lib/elementary/elc_fileselector.c
+++ b/src/lib/elementary/elc_fileselector.c
@@ -2406,6 +2406,11 @@ _properties_ready(void *data, const Efl_Event *ev)
           Eina_Bool is_dir = EINA_FALSE;
 
           value = efl_model_property_get(ev->object, "is_dir");
+          if (!eina_value_type_get(value))
+            {
+               ERR("Empty type for 'is_dir'");
+               return;
+            }
           if (eina_value_type_get(value) != EINA_VALUE_TYPE_BOOL)
             {
                ERR("Unexpected type for 'is_dir': '%s' with value '%s'.", 
eina_value_type_get(value)->name, eina_value_to_string(value));
@@ -2471,6 +2476,11 @@ _elm_fileselector_selected_set_internal(Evas_Object 
*obj, const char *path)
 
    efl_event_callback_add(pd->target, EFL_MODEL_EVENT_PROPERTIES_CHANGED, 
_properties_ready, obj);
    value = efl_model_property_get(pd->target, "is_dir");
+   if (!eina_value_type_get(value))
+     {
+        ERR("Empty type for 'is_dir'");
+        goto clean_up;
+     }
    if (eina_value_type_get(value) == EINA_VALUE_TYPE_ERROR)
      {
         Eina_Error err = 0;
@@ -2507,6 +2517,11 @@ 
_elm_fileselector_elm_interface_fileselector_selected_model_set(Eo *obj, Elm_Fil
 
    efl_event_callback_add(pd->target, EFL_MODEL_EVENT_PROPERTIES_CHANGED, 
_properties_ready, obj);
    value = efl_model_property_get(pd->target, "is_dir");
+   if (!eina_value_type_get(value))
+     {
+        ERR("Empty type for 'is_dir'");
+        goto clean_up;
+     }
    if (eina_value_type_get(value) == EINA_VALUE_TYPE_ERROR)
        {
           Eina_Error err = 0;

--