hermet pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=57531de4448e7e621490cd2e07f4042f01a1dbf3

commit 57531de4448e7e621490cd2e07f4042f01a1dbf3
Author: JunsuChoi <jsuya.c...@samsung.com>
Date:   Wed Feb 26 16:35:28 2020 +0900

    elm_slider: Add return value check
    
    Summary:
    Calling eina_value_get() without checking return value.
    CID: 1400991
    
    Test Plan: N/A
    
    Reviewers: YOhoho, Hermet, Jaehyun_Cho, CHAN
    
    Subscribers: cedric, #reviewers, #committers
    
    Tags: #efl
    
    Differential Revision: https://phab.enlightenment.org/D11416
---
 src/lib/elementary/elm_slider.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/elementary/elm_slider.c b/src/lib/elementary/elm_slider.c
index 2c6c26b84d..8aa6536a7a 100644
--- a/src/lib/elementary/elm_slider.c
+++ b/src/lib/elementary/elm_slider.c
@@ -1357,7 +1357,7 @@ _indi_default_format_cb(void *data, Eina_Strbuf *str, 
const Eina_Value value)
 
    if (type != EINA_VALUE_TYPE_DOUBLE) return EINA_FALSE;
 
-   eina_value_get(&value, &v);
+   if (!eina_value_get(&value, &v)) return EINA_FALSE;
    eina_strbuf_append_printf(str, sd->indi_template, v);
 
    return EINA_TRUE;

-- 


Reply via email to