hermet pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=720db8694ce26f5f29efe79a3e125ccb6fbc1b14
commit 720db8694ce26f5f29efe79a3e125ccb6fbc1b14
Author: JunsuChoi <jsuya.c...@samsung.com>
Date: Mon Apr 13 13:41:17 2020 +0900
Ector: Refer to visibility of Ector_Renderer when doing rle_update.
Summary:
An object with visibility false may not have a normal path or data.
It can cause invalid access or affect other ector renderers.
This is a patch to prevent them.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11689
---
src/lib/ector/software/ector_renderer_software_shape.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/ector/software/ector_renderer_software_shape.c
b/src/lib/ector/software/ector_renderer_software_shape.c
index 0db1ea2a70..d8d804db22 100644
--- a/src/lib/ector/software/ector_renderer_software_shape.c
+++ b/src/lib/ector/software/ector_renderer_software_shape.c
@@ -535,8 +535,8 @@ _need_update_rle(Eo *obj,
Ector_Renderer_Software_Shape_Data *pd)
{
if (pd->task) return pd->task;
- if (!_generate_stroke_data(pd) &&
- !_generate_shape_data(pd))
+ if (!pd->base->visibility || (!_generate_stroke_data(pd) &&
+ !_generate_shape_data(pd)))
return NULL;
const Efl_Gfx_Path_Command *cmds;
--
