sanghyeonlee pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=279cc45132050bb252340565455e60eadb34ceb4
commit 279cc45132050bb252340565455e60eadb34ceb4 Author: SangHyeon Jade Lee <[email protected]> Date: Tue Aug 4 14:18:01 2020 +0900 elm : fix return of gengrid item swap anim to prevent animation memory leak. Summary: this is memory leak fix on gengrid item move. when animation reached 1.0, it finish all animation and returns EINA_FALSE to delete current animation. Test Plan: N/A Reviewers: eagleeye Reviewed By: eagleeye Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12083 --- src/lib/elementary/elm_gengrid.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib/elementary/elm_gengrid.c b/src/lib/elementary/elm_gengrid.c index baf4f8a56f..132b7aa14f 100644 --- a/src/lib/elementary/elm_gengrid.c +++ b/src/lib/elementary/elm_gengrid.c @@ -2849,6 +2849,7 @@ _item_move_cb(void *data, double pos) double frame = pos; Evas_Coord xx1, yy1, xx2, yy2; double dx, dy; + Eina_Bool ret = EINA_TRUE; switch (sd->reorder.tween_mode) { @@ -2910,10 +2911,11 @@ _item_move_cb(void *data, double pos) efl_event_callback_legacy_call (sd->obj, ELM_GENGRID_EVENT_MOVED, EO_OBJ(sd->reorder.it1)); sd->reorder.running = EINA_FALSE; + ret = EINA_FALSE; } _elm_widget_focus_highlight_start(sd->obj); - return EINA_TRUE; + return ret; } static void --
