hermet pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=875f05cef53a973eee7fe25abdbcb824896f9d0e
commit 875f05cef53a973eee7fe25abdbcb824896f9d0e
Author: Woochanlee <wc0917....@samsung.com>
Date: Thu Sep 17 17:23:41 2020 +0900
evas_outbuf: Fix memory leak.
Summary: In certain use cases, when image data is created twice, the
existing memory pointer is isolated and a memory leak occurs.
Reviewers: raster, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8813
Differential Revision: https://phab.enlightenment.org/D12148
---
src/modules/evas/engines/buffer/evas_outbuf.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/modules/evas/engines/buffer/evas_outbuf.c
b/src/modules/evas/engines/buffer/evas_outbuf.c
index 545ff096ed..d143179f21 100644
--- a/src/modules/evas/engines/buffer/evas_outbuf.c
+++ b/src/modules/evas/engines/buffer/evas_outbuf.c
@@ -45,8 +45,9 @@ evas_buffer_outbuf_buf_update_fb(Outbuf *buf, int w, int h,
Outbuf_Depth depth,
if ((buf->depth == OUTBUF_DEPTH_ARGB_32BPP_8888_8888) &&
(buf->dest) && (buf->dest_row_bytes == (buf->w * sizeof(DATA32))))
{
- memset(buf->dest, 0, h * buf->dest_row_bytes);
- buf->priv.back_buf =
+ memset(buf->dest, 0, h * buf->dest_row_bytes);
+ if (buf->priv.back_buf)
evas_cache_image_drop(&buf->priv.back_buf->cache_entry);
+ buf->priv.back_buf =
(RGBA_Image *) evas_cache_image_data(evas_common_image_cache_get(),
w, h, buf->dest,
1, EVAS_COLORSPACE_ARGB8888);
@@ -54,6 +55,7 @@ evas_buffer_outbuf_buf_update_fb(Outbuf *buf, int w, int h,
Outbuf_Depth depth,
else if ((buf->depth == OUTBUF_DEPTH_RGB_32BPP_888_8888) &&
(buf->dest) && (buf->dest_row_bytes == (buf->w * sizeof(DATA32))))
{
+ if (buf->priv.back_buf)
evas_cache_image_drop(&buf->priv.back_buf->cache_entry);
buf->priv.back_buf =
(RGBA_Image *) evas_cache_image_data(evas_common_image_cache_get(),
w, h, buf->dest,
--
