netstar pushed a commit to branch master.

http://git.enlightenment.org/apps/evisum.git/commit/?id=b8efdc0a1814ade09d4dac7e26e1056da4b301ad

commit b8efdc0a1814ade09d4dac7e26e1056da4b301ad
Author: Alastair Poole <nets...@gmail.com>
Date:   Mon Sep 28 15:46:44 2020 +0100

    ui: dont do this...
    
    Might be wrong but I think manually waiting for threads is not
    good practice. I don't remember where I learnt this for EFL but
    it doesm't seem to be a good idea, the main loop should handle this?
---
 src/bin/ui/ui.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/src/bin/ui/ui.c b/src/bin/ui/ui.c
index 498cbf0..b4bae7a 100644
--- a/src/bin/ui/ui.c
+++ b/src/bin/ui/ui.c
@@ -1594,23 +1594,6 @@ evisum_ui_shutdown(Ui *ui)
 void
 evisum_ui_del(Ui *ui)
 {
-   evas_object_del(ui->win);
-
-   if (ui->timer_pid)
-     ecore_timer_del(ui->timer_pid);
-
-   if (ui->thread_system)
-     ecore_thread_cancel(ui->thread_system);
-
-   if (ui->thread_process)
-     ecore_thread_cancel(ui->thread_process);
-
-   if (ui->thread_system)
-     ecore_thread_wait(ui->thread_system, 1.0);
-
-   if (ui->thread_process)
-     ecore_thread_wait(ui->thread_process, 1.0);
-
    _proc_pid_cpu_times_free(ui);
 
    if (ui->cache)

-- 


Reply via email to