[EGIT] [core/efl] master 02/07: eldbus_fake_server: Fix unchecked return value

[Christopher Michael]

devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=3a07f18294e73f0b306077861d7b54a06130fc06

commit 3a07f18294e73f0b306077861d7b54a06130fc06
Author: Christopher Michael <devilho...@comcast.net>
Date:   Thu Feb 25 09:18:46 2021 -0500

    eldbus_fake_server: Fix unchecked return value
    
    Small patch to check return values of
    eldbus_message_iter_arguments_get reported by Coverity.
    
    Fixes CID1401042
---
 src/tests/eldbus/eldbus_fake_server.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/tests/eldbus/eldbus_fake_server.c 
b/src/tests/eldbus/eldbus_fake_server.c
index 41d4b1f7a4..32f5b9bd17 100644
--- a/src/tests/eldbus/eldbus_fake_server.c
+++ b/src/tests/eldbus/eldbus_fake_server.c
@@ -153,12 +153,20 @@ _fake_server_property_set(const Eldbus_Service_Interface 
*iface,
    ck_assert_ptr_ne(NULL, data);
 
    if (strcmp(propname, FAKE_SERVER_WRITEONLY_PROPERTY) == 0)
-     eldbus_message_iter_arguments_get(iter, "i", &data->writeonly_property);
-   else
-   if (strcmp(propname, FAKE_SERVER_READWRITE_PROPERTY) == 0)
-     eldbus_message_iter_arguments_get(iter, "i", &data->readwrite_property);
+     {
+        if (!eldbus_message_iter_arguments_get(iter, "i", 
&data->writeonly_property))
+          ck_abort_msg("error getting iter arguments on 
_fake_server_property_set");
+     }
    else
-     return eldbus_message_error_new(msg, "Invalid property", "Invalid 
property.");
+     {
+        if (strcmp(propname, FAKE_SERVER_READWRITE_PROPERTY) == 0)
+          {
+             if (!eldbus_message_iter_arguments_get(iter, "i", 
&data->readwrite_property))
+               ck_abort_msg("error getting iter arguments on 
_fake_server_property_set");
+          }
+        else
+          return eldbus_message_error_new(msg, "Invalid property", "Invalid 
property.");
+     }
 
    return eldbus_message_method_return_new(msg);
 }

--