davemds pushed a commit to branch master.
http://git.enlightenment.org/apps/espionage.git/commit/?id=1886497401d756d17ad9938cf2df44a19c4958c1
commit 1886497401d756d17ad9938cf2df44a19c4958c1
Author: Dave Andreoli <d...@gurumeditation.it>
Date: Mon Apr 26 12:04:26 2021 +0200
warning --
item could be undefined, refactor the function to be more accurate
---
espionage/espionage.py | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/espionage/espionage.py b/espionage/espionage.py
index a3a0476..f5f534a 100644
--- a/espionage/espionage.py
+++ b/espionage/espionage.py
@@ -420,13 +420,13 @@ class NamesList(Genlist):
self.activatable_group, 0, None)
def service_add(self, name):
- if name.startswith(':'):
- if options.show_private_stuff:
- item = self.item_sorted_insert(self.itc, name, self.sort_cb,
- self.private_group, 0, None)
- else:
- item = self.item_sorted_insert(self.itc, name, self.sort_cb,
- self.public_group, 0, None)
+ is_private = name.startswith(':')
+ if is_private and not options.show_private_stuff:
+ return
+
+ group_item = self.private_group if is_private else self.public_group
+ item = self.item_sorted_insert(self.itc, name, self.sort_cb,
+ group_item, 0, None)
if self.waiting_activation is not None and name ==
self.waiting_activation:
self.waiting_popup.delete()
--
