raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=c02b796fdb0960411b24576f654a03f0e765a842
commit c02b796fdb0960411b24576f654a03f0e765a842
Author: Felipe Magno de Almeida <fel...@expertise.dev>
Date: Sun May 23 20:08:33 2021 +0100
elementary: Add EOAPI definition in Elementary to allow removal in other
libraries
Summary:
Patch from a series of patches to rename EAPI symbols to specific
library DSOs.
= The Rationale =
EAPI was designed to be able to pass
`__attribute__ ((visibility ("default")))` for symbols with
GCC, which would mean that even if -fvisibility=hidden was used
when compiling the library, the needed symbols would get exported.
MSVC __almost__ works like GCC (or mingw) in which you can
declare everything as export and it will just work (slower, but
it will work). But there's a caveat: global variables will not
work the same way for MSVC, but works for mingw and GCC.
For global variables (as opposed to functions), MSVC requires
correct DSO visibility for MSVC: instead of declaring a symbol as
export for everything, you need to declare it as import when
importing from another DSO and export when defining it locally.
With current EAPI definitions, we get the following example
working in mingw and MSVC (observe it doesn't define any global
variables as exported symbols).
Example 1:
dll1:
```
EAPI void foo(void);
EAPI void bar()
{
foo();
}
```
dll2:
```
EAPI void foo()
{
printf ("foo\n");
}
```
This works fine with API defined as __declspec(dllexport) in both
cases and for gcc defining as
`__atttribute__((visibility("default")))`.
However, the following:
Example 2:
dll1:
```
EAPI extern int foo;
EAPI void foobar(void);
EAPI void bar()
{
foo = 5;
foobar();
}
```
dll2:
```
EAPI int foo = 0;
EAPI void foobar()
{
printf ("foo %d\n", foo);
}
```
This will work on mingw but will not work for MSVC. And that's why
EAPI is the only solution that worked for MSVC.
Co-authored-by: João Paulo Taylor Ienczak Zanette <jpaulo...@gmail.com>
Co-authored-by: Ricardo Campos <ricardo.cam...@expertise.dev>
Co-authored-by: Lucas Cavalcante de Sousa <lucks.so...@gmail.com>
Reviewers: vtorri, raster
Reviewed By: raster
Subscribers: raster, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D12273
---
src/lib/elementary/Elementary.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/lib/elementary/Elementary.h b/src/lib/elementary/Elementary.h
index a64406de43..6d0a33a643 100644
--- a/src/lib/elementary/Elementary.h
+++ b/src/lib/elementary/Elementary.h
@@ -88,6 +88,9 @@
#ifdef EAPI_WEAK
# undef EAPI_WEAK
#endif
+#ifdef EOAPI
+# undef EOAPI
+#endif
#ifdef _WIN32
# ifdef EFL_BUILD
@@ -116,7 +119,7 @@
#endif
#define EWAPI EAPI EAPI_WEAK
-
+#define EOAPI EAPI
/* allow usage from c++ */
#ifdef __cplusplus
--
