Dear diary, on Sun, Apr 17, 2005 at 05:24:20PM CEST, I got a letter
where Daniel Barkalow <[EMAIL PROTECTED]> told me that...
> This adds support to revision.h for parsing commit records (but not going
> any further than parsing a single record). Something like this is needed
> by anything that uses revision.h, but older programs open-code it.
>
> Signed-Off-By: Daniel Barkalow <[EMAIL PROTECTED]>
Could you please convert the current users (rev-tree.c and fsck-cache.c)
to use this in the same patch?
> Index: revision.h
> ===================================================================
> --- 45f926575d2c44072bfcf2317dbf3f0fbb513a4e/revision.h (mode:100644
> sha1:28d0de3261a61f68e4e0948a25a416a515cd2e83)
> +++ 37a0b01b85c2999243674d48bfc71cdba0e5518e/revision.h (mode:100644
> sha1:523bde6e14e18bb0ecbded8f83ad4df93fc467ab)
> @@ -24,6 +24,7 @@
> unsigned int flags;
> unsigned char sha1[20];
> unsigned long date;
> + unsigned char tree[20];
> struct parent *parent;
> };
>
> @@ -111,4 +112,29 @@
> }
> }
>
> +static int parse_commit_object(struct revision *rev)
> +{
> + if (!(rev->flags & SEEN)) {
> + void *buffer, *bufptr;
> + unsigned long size;
> + char type[20];
> + unsigned char parent[20];
> +
> + rev->flags |= SEEN;
> + buffer = bufptr = read_sha1_file(rev->sha1, type, &size);
> + if (!buffer || strcmp(type, "commit"))
> + return -1;
> + get_sha1_hex(bufptr + 5, rev->tree);
> + bufptr += 46; /* "tree " + "hex sha1" + "\n" */
> + while (!memcmp(bufptr, "parent ", 7) &&
> + !get_sha1_hex(bufptr+7, parent)) {
> + add_relationship(rev, parent);
> + bufptr += 48; /* "parent " + "hex sha1" + "\n" */
> + }
> + //rev->date = parse_commit_date(bufptr);
I don't like this.
> + free(buffer);
> + }
> + return 0;
> +}
> +
> #endif /* REVISION_H */
BTW, I think that in longer term having this stuffed in revision.h is a
bad idea, we should have revision.c. I will accept patches putting the
stuff to revision.h for now, though (unless it gets outrageous).
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
