On Sunday 17 April 2005 08:03 am, Petr Baudis wrote:
> Dear diary, on Sun, Apr 17, 2005 at 07:36:51AM CEST, I got a letter
> where Steven Cole <[EMAIL PROTECTED]> told me that...
> > This is a fairly trivial addition, but if users are adding remote
> > repositories
> > with git addremote, then those users should be able to list out the remote
> > list without having to know the details of where the remotes file is kept.
>
> Could you please send your patches inline? (Either in the body or with
> correct content-disposition header.)
>
> You got the return values other way around and you are missing a
> copyright notice at the top; you should also mention that you take no
> parameters.
>
> Please use -s instead of -e, since it is more appropriate in this case.
> Also, you should report the "no remotes" message to stderr. And always
> exit when you found that .git/remotes exists, not only if cat succeeds.
>
> Kind regards,
>
Thanks for the fixes. Here's a better version.
Steven
This is a fairly trivial addition, but if users are adding remote repositories
with git addremote, then those users should be able to list out the remote
list without having to know the details of where the remotes file is kept.
Signed-off-by: Steven Cole <[EMAIL PROTECTED]>
diff -urN git-pasky.orig/git git-pasky/git
--- git-pasky.orig/git 2005-04-17 15:02:37.000000000 -0600
+++ git-pasky/git 2005-04-17 15:04:23.000000000 -0600
@@ -41,6 +41,7 @@
log
ls [TREE_ID]
lsobj [OBJTYPE]
+ lsremote
merge -b BASE_ID FROM_ID
pull [RNAME]
rm FILE...
@@ -105,6 +106,7 @@
"log") gitlog.sh "$@";;
"ls") gitls.sh "$@";;
"lsobj") gitlsobj.sh "$@";;
+"lsremote") gitlsremote.sh "$@";;
"merge") gitmerge.sh "$@";;
"pull") gitpull.sh "$@";;
"rm") gitrm.sh "$@";;
diff -urN git-pasky.orig/gitlsremote.sh git-pasky/gitlsremote.sh
--- git-pasky.orig/gitlsremote.sh 1969-12-31 17:00:00.000000000 -0700
+++ git-pasky/gitlsremote.sh 2005-04-17 16:20:48.000000000 -0600
@@ -0,0 +1,11 @@
+#!/bin/sh
+#
+# Lists remote GIT repositories
+# Copyright (c) Steven Cole 2005
+#
+# Takes no parameters
+#
+[ -s .git/remotes ] && cat .git/remotes
+[ -s .git/remotes ] && exit
+
+echo "List of remotes is empty. See git addremote." >&2
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
